Closed Bug 1118373 Opened 10 years ago Closed 9 years ago

Video volume slider looks truncated when video element has no fullscreen button (e.g. when it's in an iframe)

Categories

(Toolkit :: Video/Audio Controls, defect)

Product:
Toolkit
Component:
Video/Audio Controls
Version:
28 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla37
Iteration:
37.3 - 12 Jan
Tracking Flags:
Tracking Status
firefox34 --- wontfix
firefox35 --- wontfix
firefox36 --- verified
firefox37 --- verified
firefox-esr31 --- affected

People

(Reporter: davidavilasilva, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

firefox-iframe-video-bug.png
114.61 KB, image/png
Details
iframe.html
247 bytes, text/html
Details
Testcase
196 bytes, text/html
Details 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

With Firefox 34 for Windows 8.1...
1. Create an HTML page that loads an iframe containing a <video> element. The source can be an mp4 or an ogv; it doesn't make a difference.
2. Load the parent page in the browser.


Actual results:

The controls are cut off on the right (see attachment).


Expected results:

The controls should be scaled so that the full-screen button is also visible.
OS: Mac OS X → Windows 8.1
Could you attach the testcase?
Flags: needinfo?(davidavilasilva)
Sure. Here's the code for the two html files:

<!doctype html>
<html>
<head>
</head>
<body>
<iframe src="iframe.html" style="width: 800px; height: 800px;"></iframe>
</body>
</html>


<!doctype html>
<html>
<head>
</head>
<body>
<video id="video-element" controls>
<source src="https://ia802302.us.archive.org/22/items/journey_to_the_center_of_a_triangle/journey_to_the_center_of_a_triangle.ogv"/>
</video>
</body>
</html>
Flags: needinfo?(davidavilasilva)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee425b3ccc29&tochange=7f4ce3bb50d0

Regressed by: Bug 649490
Blocks: 649490
Status: UNCONFIRMED → NEW
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
status-firefox-esr31: --- → affected
Component: Untriaged → Video/Audio Controls
Ever confirmed: true
Flags: needinfo?(jaws)
Keywords: regression
Product: Firefox → Toolkit
Version: 34 Branch → 28 Branch
Attached file reporter's testcase (obsolete) — 

    
  
Summary: Controls are not displayed correctly when video element is in iframe → Controls are not displayed correctly when video element is in iframe, (Volume slider should not be truncated)

    
  
Flags: needinfo?(gijskruitbosch+bugs)

    
    

    
  

      
      
      
      

        Attached file
          
        iframe.html
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached file
          
        Testcase
        — 
      

    


  

        Attachment #8545305 -
        Attachment is obsolete: true

    
    

    
  
The fullscreen button is hidden expressly through JS, not just cut off. This is because the iframe doesn't have the allowfullscreen attribute. This is correct.


The volume control looks cut off because the fullscreen button is hidden. That's a design issue that we should fix; the easiest is probably by adding the appropriate margin (28px button - 16px icon = 12px split on both sides, so probably 6px ?) and then adding the same negative margin on the fullscreen button.

I wonder if/why this doesn't affect <audio> elements, too...
Flags: needinfo?(gijskruitbosch+bugs) → firefox-backlog+
Summary: Controls are not displayed correctly when video element is in iframe, (Volume slider should not be truncated) → Video volume slider looks truncated when video element has no fullscreen button (e.g. when it's in an iframe)

    
  
Points: --- → 3
OS: Windows 8.1 → All
Hardware: x86 → All

    
    

    
  
Yeah, we should probably set an attribute which uses CSS to hide the fullscreen button as well as add the extra margin-end.
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED

    
    

    
  
Bug 1074744 has a patch in there that fixes this issue.

David, can you test out a build with the fix in it? Builds should start appearing at https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jwein@mozilla.com-3c9233b74116/ within the next 6 hours.
See Also:  → 1074744

    
    

    
  
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> Bug 1074744 has a patch in there that fixes this issue.
> 
> David, can you test out a build with the fix in it? Builds should start
> appearing at
> https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jwein@mozilla.com-
> 3c9233b74116/ within the next 6 hours.

This WFM on OS X.

    
    

    
  
It also WFM on OS X. I want to test it on Windows but am having some unrelated problems with running Windows on Virtual Box.

    
    

    
  
Marking fixed per bug 1074744. I'm not sure this is a serious enough issue on its own to warrant an ESR patch (I lean towards 'no'). Jared?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox34:
          affected → wontfix

          status-firefox35:
          affected → wontfix

          status-firefox37:
          affected → fixed
Flags: needinfo?(jaws)
Resolution: --- → FIXED

    
  
Target Milestone: --- → mozilla37

    
  
Iteration: --- → 37.3 - 12 Jan
Flags: qe-verify+
Flags: in-testsuite+

    
    

    
  
No, we shouldn't do an ESR patch as this has existed for a long time and we haven't heard of many people encountering it. I would prefer to wait versus complicating the testing matrix.
Flags: needinfo?(jaws)

    
    

    
  
Reproduced with Nightly 2015-01-06 with the attached testcase from comment 6.
Verified as fixed with Fx 36 beta 1 build 2 (20150114125146) and DevEd 37.0a2 (20150119004009) on Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 - volume slider is no longer truncated.
Status: RESOLVED → VERIFIED

          status-firefox36:
          affected → verified

          status-firefox37:
          fixed → verified
QA Contact: alexandra.lucinet

    
  
Flags: qe-verify+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: